Unit Testing: Do no run in debug mode in order to reduce logging#13241
Unit Testing: Do no run in debug mode in order to reduce logging#13241valentijnscholten merged 3 commits intodevfrom
Conversation
Viewing a failed test in the GHA logs is not very helpful without rendering the raw view because there are 50k+ lines of debug logs. Reducing the logging verbosity would make the tests quite a bit faster as well as finding failures easier in the GHA UI
|
When I look at the output of tests the biggest generators of output are the vcr related tests. Maybe a rerecording will reduce the output? There's also some dedupe and false positives history tests which put out lots of logging. Maybe those log statements can be commented out. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Yep - they are debug logging the entire request 🥴 I would prefer to keep those logs in case someone needs them. not sure why the tests are ignoring the log level. Will make more time for this soon |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Now that this feature has been live for a while, I think we can reduce the logging a bit. Noticed a lot of logs for this during #13241
valentijnscholten
left a comment
valentijnscholten
left a comment
There was a problem hiding this comment.
Should we put a few lines in the docker readme on how to get DEBUG log output during unit tests?
|
sure thing |
Turns out we have two docker compose override files: one for GHA and one for locally running tests that is still running in debug mode. The override specified in the docker docs is the latter option with debug mode enabled by default. I think we are fine to proceed with this PR as is |
Now that this feature has been live for a while, I think we can reduce the logging a bit. Noticed a lot of logs for this during #13241
Sure Thing as in "Yes, I (Cody) will do that" or as in "I (Cody) happily wait for someone to do that". I can try to deduce it from the PR, but not sure if both changes are needed and what their side effects are. |
…3748) Now that this feature has been live for a while, I think we can reduce the logging a bit. Noticed a lot of logs for this during DefectDojo#13241
…ectDojo#13241) * Unit Testing: Do no run in debug mode in order to reduce logging Viewing a failed test in the GHA logs is not very helpful without rendering the raw view because there are 50k+ lines of debug logs. Reducing the logging verbosity would make the tests quite a bit faster as well as finding failures easier in the GHA UI * Remove verbosity from unit test commands
5 participants
Viewing a failed test in the GHA logs is not very helpful without rendering the raw view because there are 50k+ lines of debug logs. Reducing the logging verbosity would make the tests quite a bit faster as well as finding failures easier in the GHA UI